Move CIs to use docker builds #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that #1234 has landed and anyone can run CI / Release builds locally move GHA to use the same flow.
silvasean
requested changes
Aug 30, 2022
silvasean
approved these changes
Sep 1, 2022
sjain-stanford
approved these changes
Sep 1, 2022
|
@silvasean if you have a quick fix for #1334 lets land that and then this change. If not we can revert the last shape lib test and re-land after this lands. I would like to try and land this today so I can tend to the CI over the long weekend in case anything needs tweaking / reverts etc. |
|
Let's land this! The fix is in #1338 -- feel free to merge it yourself if needed. |
|
awesome thanks. will wait for it to go green and land #1338 and then land this when green. |
|
Awesome. Thanks Anush for all the hard work here and sorry for these last minute speed bumps on the generated files! |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Signed-off-by: Whitney Tsang <whitneyt@ca.ibm.com>
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed. Signed-off-by: Whitney Tsang whitneyt@ca.ibm.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #1234 has landed and anyone can run CI / Release builds locally move GHA to use the same flow.